diff options
| author | Daniel Silverstone <dsilvers@digital-scurf.org> | 2019-10-21 10:01:52 +0100 |
|---|---|---|
| committer | Daniel Silverstone <dsilvers@digital-scurf.org> | 2019-10-21 10:03:46 +0100 |
| commit | a5766db2b9516dbf02cf2d023d777aef4e0470c1 (patch) | |
| tree | e68c8cdbe4d8f4d6be79241ea8299959911a806b | |
| parent | 813d0c70fe06090256b09356869f07e238c986a1 (diff) | |
| download | netsurf-a5766db2b9516dbf02cf2d023d777aef4e0470c1.tar.gz netsurf-a5766db2b9516dbf02cf2d023d777aef4e0470c1.tar.bz2 | |
fetchers/curl: Restrict AUTH to BASIC
cURL will prevent channel reuse if NTLM auth is enabled because
NTLM authenticates a channel not a request. As such we were
unable to reuse curl handles since we handed off connection
reuse to curl instead of our own handle cache. This mitigates
the effect, though curl authors are looking at fixing it upstream
too.
Fixes: #2707
Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
| -rw-r--r-- | content/fetchers/curl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/content/fetchers/curl.c b/content/fetchers/curl.c index f24e3de86..2644c68d4 100644 --- a/content/fetchers/curl.c +++ b/content/fetchers/curl.c @@ -840,7 +840,7 @@ static CURLcode fetch_curl_set_options(struct curl_fetch_info *f) } if ((auth = urldb_get_auth_details(f->url, NULL)) != NULL) { - SETOPT(CURLOPT_HTTPAUTH, CURLAUTH_ANY); + SETOPT(CURLOPT_HTTPAUTH, CURLAUTH_BASIC); SETOPT(CURLOPT_USERPWD, auth); } else { SETOPT(CURLOPT_USERPWD, NULL); |