From 2467a0a99080c0d707fcf443a2d91deed1a76c1d Mon Sep 17 00:00:00 2001 From: Vincent Sanders Date: Fri, 9 Jun 2017 19:51:12 +0100 Subject: fix coverity issue 1372473 Out-of-bounds write --- content/urldb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/content/urldb.c b/content/urldb.c index f5533686e..313ec316d 100644 --- a/content/urldb.c +++ b/content/urldb.c @@ -696,8 +696,8 @@ static bool urldb__host_is_ip_address(const char *host) } ipv6_addr_len = host_len - 2; - if (ipv6_addr_len > sizeof(ipv6_addr)) { - ipv6_addr_len = sizeof(ipv6_addr); + if (ipv6_addr_len >= sizeof(ipv6_addr)) { + ipv6_addr_len = sizeof(ipv6_addr) - 1; } strncpy(ipv6_addr, sane_host + 1, ipv6_addr_len); ipv6_addr[ipv6_addr_len] = '\0'; -- cgit v1.2.3