From 5105249bf7aa91fc84fd53af06cc073ff7987168 Mon Sep 17 00:00:00 2001
From: Chris Young <chris@unsatisfactorysoftware.co.uk>
Date: Wed, 2 Jul 2014 18:35:16 +0100
Subject: tidy up schedule removal

---
 amiga/schedule.c | 59 +++++++++++++++++++++++++++++---------------------------
 1 file changed, 31 insertions(+), 28 deletions(-)

diff --git a/amiga/schedule.c b/amiga/schedule.c
index 9aa74881f..d0a0570dd 100755
--- a/amiga/schedule.c
+++ b/amiga/schedule.c
@@ -53,6 +53,32 @@ static void ami_remove_timer_event(struct nscallback *nscb)
 	}
 }
 
+static struct nscallback *ami_schedule_locate(void (*callback)(void *p), void *p, bool remove)
+{
+	PblIterator *iterator;
+	struct nscallback *nscb;
+	bool found_cb = false;
+
+	/* check there is something on the list */
+        if (schedule_list == NULL) return NULL;
+	if(pblHeapIsEmpty(schedule_list)) return NULL;
+
+	iterator = pblHeapIterator(schedule_list);
+
+	while ((nscb = pblIteratorNext(iterator)) != -1) {
+		if ((nscb->callback == callback) && (nscb->p == p)) {
+			if (remove == true) pblIteratorRemove(iterator);
+			found_cb = true;
+			break;
+		}
+	};
+
+	pblIteratorFree(iterator);
+
+	if (found_cb == true) return nscb;
+		else return NULL;
+}
+
 /**
  * Unschedule a callback.
  *
@@ -66,36 +92,12 @@ static nserror schedule_remove(void (*callback)(void *p), void *p)
 {
 	PblIterator *iterator;
 	struct nscallback *nscb;
-	bool restoreheap = false;
-
-	/* check there is something on the list to remove */
-        if (schedule_list == NULL)
-	{
-                return NSERROR_OK;
-	}
-
-	if(pblHeapIsEmpty(schedule_list))
-	{
-		return NSERROR_OK;
-	}
-
-	iterator = pblHeapIterator(schedule_list);
-
-	while ((nscb = pblIteratorNext(iterator)) != -1)
-	{
-		if((nscb->callback == callback) && (nscb->p == p))
-		{
-			ami_remove_timer_event(nscb);
-			pblIteratorRemove(iterator);
-			FreeVec(nscb);
-			restoreheap = true;
-		}
-	};
 
-	pblIteratorFree(iterator);
+	nscb = ami_schedule_locate(callback, p, true);
 
-	if(restoreheap)
-	{
+	if(nscb != NULL) {
+		ami_remove_timer_event(nscb);
+		FreeVec(nscb);
 		pblHeapConstruct(schedule_list);
 	}
 
@@ -257,3 +259,4 @@ nserror ami_schedule(int t, void (*callback)(void *p), void *p)
 
 	return NSERROR_OK;
 }
+
-- 
cgit v1.2.3