diff options
author | Vincent Sanders <vince@kyllikki.org> | 2014-11-04 19:57:51 +0000 |
---|---|---|
committer | Vincent Sanders <vince@kyllikki.org> | 2014-11-04 20:41:31 +0000 |
commit | d85b74fd727833be1d8adf76d293edcfe091a049 (patch) | |
tree | 56a94603c2284f75f2e3fb9d97cc75ae9b6de5a2 | |
parent | c637cd04b1a748f2a46efabd90b56469f8b7ba10 (diff) | |
download | netsurf-d85b74fd727833be1d8adf76d293edcfe091a049.tar.gz netsurf-d85b74fd727833be1d8adf76d293edcfe091a049.tar.bz2 |
change logic to check for false instead of not true to fix coverity 1250328
-rwxr-xr-x | utils/coverity-build.sh | 2 | ||||
-rw-r--r-- | utils/nsurl.c | 8 |
2 files changed, 5 insertions, 5 deletions
diff --git a/utils/coverity-build.sh b/utils/coverity-build.sh index a94ee4401..05696f7e2 100755 --- a/utils/coverity-build.sh +++ b/utils/coverity-build.sh @@ -46,7 +46,7 @@ export LD_LIBRARY_PATH=${LD_LIBRARY_PATH}:${PREFIX}/lib export PATH=${PATH}:${PREFIX}/bin # Coverity tools location -COVERITY_PREFIX=${COVERITY_PREFIX:-/opt/coverity/cov-analysis-linux64-6.6.1} +COVERITY_PREFIX=${COVERITY_PREFIX:-/opt/coverity/cov-analysis-linux64-7.0.2} COVERITY_VERSION=$(git rev-parse HEAD) export PATH=${PATH}:${COVERITY_PREFIX}/bin diff --git a/utils/nsurl.c b/utils/nsurl.c index 5992c2b22..96b3f3681 100644 --- a/utils/nsurl.c +++ b/utils/nsurl.c @@ -2222,10 +2222,10 @@ nserror nsurl_nice(const nsurl *url, char **result, bool remove_extensions) /* extract the last component of the path, if possible */ if ((url->components.path != NULL) && - lwc_string_length(url->components.path) != 0 && - lwc_string_isequal(url->components.path, - corestring_lwc_slash_, &match) == lwc_error_ok && - match != true) { + (lwc_string_length(url->components.path) != 0) && + (lwc_string_isequal(url->components.path, + corestring_lwc_slash_, &match) == lwc_error_ok) && + (match == false) { bool first = true; bool keep_looking; |