diff options
| author | John Mark Bell <jmb@netsurf-browser.org> | 2009-12-18 00:11:37 +0000 |
|---|---|---|
| committer | John Mark Bell <jmb@netsurf-browser.org> | 2009-12-18 00:11:37 +0000 |
| commit | 1f4bb413011768267242023fa66830f156951fa0 (patch) | |
| tree | 4be750662d69d5c5d950ac1c97b8e8a7a986bbde | |
| parent | d7ddeebe764c1081465d174edfa51af5b73043f0 (diff) | |
| download | netsurf-1f4bb413011768267242023fa66830f156951fa0.tar.gz netsurf-1f4bb413011768267242023fa66830f156951fa0.tar.bz2 | |
I've decided that the user probably doesn't care if setting the filetype of saved HTML documents to HTML fails or not.
More importantly, this also squashes a memory leak, and stops returning false from a function which is defined as returning -1 on error.
svn path=/trunk/netsurf/; revision=9731
| -rw-r--r-- | riscos/save.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/riscos/save.c b/riscos/save.c index 44a2b1835..b4a897424 100644 --- a/riscos/save.c +++ b/riscos/save.c @@ -1042,14 +1042,16 @@ int save_complete_htmlSaveFileFormat(const char *path, const char *filename, return -1; } snprintf(fullpath, len, "%s.%s", path, filename); + ret = htmlSaveFileFormat(fullpath, cur, encoding, format); + error = xosfile_set_type(fullpath, 0xFAF); if (error) { LOG(("xosfile_save_stamped: 0x%x: %s", - error->errnum, error->errmess)); - warn_user("SaveError", error->errmess); - return false; + error->errnum, error->errmess)); + /* Don't warn the user here -- they probably don't care */ } + free(fullpath); return ret; } |