diff options
| author | Michael Drake <tlsa@netsurf-browser.org> | 2013-10-25 12:18:46 +0100 |
|---|---|---|
| committer | Michael Drake <tlsa@netsurf-browser.org> | 2013-10-25 12:18:46 +0100 |
| commit | a921a007e626bb9a96b3c81d161bbdd8d2af7ad6 (patch) | |
| tree | 7fcf38b10c83c1fa4a0ba4c4983031fc63df81d4 /css | |
| parent | 0d03a342d93599bac661b90938a0478268881eda (diff) | |
| download | netsurf-a921a007e626bb9a96b3c81d161bbdd8d2af7ad6.tar.gz netsurf-a921a007e626bb9a96b3c81d161bbdd8d2af7ad6.tar.bz2 | |
Fix leak of cellpadding attribute value.
Diffstat (limited to 'css')
| -rw-r--r-- | css/select.c | 19 |
1 files changed, 9 insertions, 10 deletions
diff --git a/css/select.c b/css/select.c index 0f1962b5d..23666e1ba 100644 --- a/css/select.c +++ b/css/select.c @@ -2014,6 +2014,7 @@ node_presentational_hint_padding_trbl(nscss_select_ctx *ctx, dom_string *name; dom_exception exc; dom_string *cellpadding = NULL; + css_error result = CSS_PROPERTY_NOT_SET; exc = dom_node_get_node_name(node, &name); if (exc != DOM_NO_ERR) @@ -2049,20 +2050,18 @@ node_presentational_hint_padding_trbl(nscss_select_ctx *ctx, } dom_string_unref(name); - - if (cellpadding == NULL) - return CSS_PROPERTY_NOT_SET; - if (parse_dimension(dom_string_data(cellpadding), false, - &hint->data.length.value, - &hint->data.length.unit)) { - hint->status = CSS_PADDING_SET; - } else { + if (cellpadding != NULL) { + if (parse_dimension(dom_string_data(cellpadding), false, + &hint->data.length.value, + &hint->data.length.unit)) { + hint->status = CSS_PADDING_SET; + result = CSS_OK; + } dom_string_unref(cellpadding); - return CSS_PROPERTY_NOT_SET; } - return CSS_OK; + return result; } static css_error |