diff options
author | Vincent Sanders <vince@netsurf-browser.org> | 2013-02-14 18:21:11 +0000 |
---|---|---|
committer | Vincent Sanders <vince@netsurf-browser.org> | 2013-02-18 11:23:48 +0000 |
commit | b112dec78d5e8289ded3f61db96e495690ae96b5 (patch) | |
tree | 9babaed21ed2eb841b8d398e28814544c73656d9 /gtk/scaffolding.c | |
parent | 3bfb5b96a7c7cb2718a60987e69cd659ed49b9d8 (diff) | |
download | netsurf-b112dec78d5e8289ded3f61db96e495690ae96b5.tar.gz netsurf-b112dec78d5e8289ded3f61db96e495690ae96b5.tar.bz2 |
change browser_window_create and refactor all callsites
Diffstat (limited to 'gtk/scaffolding.c')
-rw-r--r-- | gtk/scaffolding.c | 108 |
1 files changed, 84 insertions, 24 deletions
diff --git a/gtk/scaffolding.c b/gtk/scaffolding.c index 3f027f88f..3ebf051dc 100644 --- a/gtk/scaffolding.c +++ b/gtk/scaffolding.c @@ -579,15 +579,28 @@ static void nsgtk_openfile_open(const char *filename) MULTIHANDLER(newwindow) { struct browser_window *bw = nsgtk_get_browser_window(g->top_level); - const char *url = nsoption_charp(homepage_url); - - if (url != NULL) - url = NULL; + const char *addr; + nsurl *url; + nserror error; - if (url == NULL) - url = NETSURF_HOMEPAGE; + if (nsoption_charp(homepage_url) != NULL) { + addr = nsoption_charp(homepage_url); + } else { + addr = NETSURF_HOMEPAGE; + } - browser_window_create(url, bw, NULL, false, false); + error = nsurl_create(addr, &url); + if (error == NSERROR_OK) { + error = browser_window_create(BROWSER_WINDOW_GO_FLAG_VERIFIABLE, + url, + NULL, + bw, + NULL); + nsurl_unref(url); + } + if (error != NSERROR_OK) { + warn_user(messages_get_errorcode(error), 0); + } return TRUE; } @@ -595,25 +608,41 @@ MULTIHANDLER(newwindow) MULTIHANDLER(newtab) { struct browser_window *bw = nsgtk_get_browser_window(g->top_level); + nsurl *url; + nserror error; - if (nsoption_bool(new_blank)) { - browser_window_create(NULL, bw, NULL, false, true); + if (!nsoption_bool(new_blank)) { + const char *addr; + if (nsoption_charp(homepage_url) != NULL) { + addr = nsoption_charp(homepage_url); + } else { + addr = NETSURF_HOMEPAGE; + } + error = nsurl_create(addr, &url); + if (error != NSERROR_OK) { + warn_user(messages_get_errorcode(error), 0); + } + } + + error = browser_window_create(BROWSER_WINDOW_GO_FLAG_VERIFIABLE | + BROWSER_WINDOW_GO_FLAG_TAB, + url, + NULL, + bw, + NULL); + if (url != NULL) { + nsurl_unref(url); + } + if (error != NSERROR_OK) { + warn_user(messages_get_errorcode(error), 0); + } else if (nsoption_bool(new_blank)) { + /** @todo what the heck is this for? */ GtkWidget *window = gtk_notebook_get_nth_page(g->notebook, -1); nsgtk_widget_override_background_color(window, - GTK_STATE_NORMAL, - 0xFFFF, 0xFFFF, 0xFFFF, 0xFFFF); - } else { - const char *url = nsoption_charp(homepage_url); - - if (url != NULL) - url = NULL; - - if (url == NULL) - url = NETSURF_HOMEPAGE; - - browser_window_create(url, bw, NULL, false, true); + GTK_STATE_NORMAL, + 0xFFFF, 0xFFFF, 0xFFFF, 0xFFFF); } - + return TRUE; } @@ -968,11 +997,25 @@ MENUHANDLER(link_openwin) struct gtk_scaffolding *g = (struct gtk_scaffolding *) data; struct gui_window *gui = g->top_level; struct browser_window *bw = nsgtk_get_browser_window(gui); + nsurl *url; + nserror error; if (current_menu_ctx.link_url == NULL) return FALSE; - browser_window_create(current_menu_ctx.link_url, bw, NULL, true, false); + error = nsurl_create(current_menu_ctx.link_url, &url); + if (error == NSERROR_OK) { + error = browser_window_create(BROWSER_WINDOW_GO_FLAG_VERIFIABLE | + BROWSER_WINDOW_GO_FLAG_HISTORY, + url, + NULL, + bw, + NULL); + nsurl_unref(url); + } + if (error != NSERROR_OK) { + warn_user(messages_get_errorcode(error), 0); + } return TRUE; } @@ -985,12 +1028,29 @@ MENUHANDLER(link_opentab) struct gtk_scaffolding *g = (struct gtk_scaffolding *) data; struct gui_window *gui = g->top_level; struct browser_window *bw = nsgtk_get_browser_window(gui); + nsurl *url; + nserror error; if (current_menu_ctx.link_url == NULL) return FALSE; temp_open_background = 1; - browser_window_create(current_menu_ctx.link_url, bw, NULL, true, true); + + error = nsurl_create(current_menu_ctx.link_url, &url); + if (error == NSERROR_OK) { + error = browser_window_create(BROWSER_WINDOW_GO_FLAG_VERIFIABLE | + BROWSER_WINDOW_GO_FLAG_HISTORY | + BROWSER_WINDOW_GO_FLAG_TAB, + url, + NULL, + bw, + NULL); + nsurl_unref(url); + } + if (error != NSERROR_OK) { + warn_user(messages_get_errorcode(error), 0); + } + temp_open_background = -1; return TRUE; |