diff options
author | Vincent Sanders <vince@netsurf-browser.org> | 2012-10-25 11:12:41 +0100 |
---|---|---|
committer | Vincent Sanders <vince@netsurf-browser.org> | 2012-10-25 11:12:41 +0100 |
commit | baf50cec89d10055217a3bb210d389694fb1d389 (patch) | |
tree | 98ba96f23f98ceecaf02fbc2e016b297a50c9a25 /image/nssprite.c | |
parent | 0b7db9b47adaf56ae937415040cf585a07eaf8cb (diff) | |
download | netsurf-baf50cec89d10055217a3bb210d389694fb1d389.tar.gz netsurf-baf50cec89d10055217a3bb210d389694fb1d389.tar.bz2 |
make image content handlers title setting use the heap instead of the stack and remove the possibility of buffer overruns
Diffstat (limited to 'image/nssprite.c')
-rw-r--r-- | image/nssprite.c | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/image/nssprite.c b/image/nssprite.c index ea05c8fe0..5f05c940a 100644 --- a/image/nssprite.c +++ b/image/nssprite.c @@ -98,7 +98,7 @@ static bool nssprite_convert(struct content *c) const char *data; unsigned long size; - char title[100]; + char *title; data = content__get_source_data(c, &size); @@ -144,9 +144,14 @@ static bool nssprite_convert(struct content *c) c->width = sprite->width; c->height = sprite->height; - snprintf(title, sizeof(title), messages_get("SpriteTitle"), - c->width, c->height, size); - content__set_title(c, title); + /* set title text */ + title = messages_get_buff("SpriteTitle", + nsurl_access_leaf(llcache_handle_get_url(c->llcache)), + c->width, c->height); + if (title != NULL) { + content__set_title(c, title); + free(title); + } bitmap_modified(nssprite->bitmap); |