summaryrefslogtreecommitdiff
path: root/render
Commit message (Collapse)AuthorAgeFilesLines
* Only iterate the form when freeing a control if there is one.Daniel Silverstone2015-06-031-14/+16
| | | | This fixes Bug#2322
* fixup all the remaining logging macro callsitesVincent Sanders2015-05-281-1/+1
| | | | | The semantic patch tool appears to have missed some difficult to reason about callsites which have now been manually cleaned up
* Change LOG() macro to be varadicVincent Sanders2015-05-2815-242/+187
| | | | | | | | | | | | This changes the LOG macro to be varadic removing the need for all callsites to have double bracketing and allows for future improvement on how we use the logging macros. The callsites were changed with coccinelle and the changes checked by hand. Compile tested for several frontends but not all. A formatting annotation has also been added which allows the compiler to check the parameters and types passed to the logging.
* put assert back to protect against bad logic in frontend drag implementationsVincent Sanders2015-05-081-0/+4
|
* remove assert if drag message contains an unknown type.Vincent Sanders2015-05-031-8/+12
| | | | | Instead of asserting if a message contains an unsupported drag type the message is now logged and ignored.
* Silence incorrect warning from gcc 4.9Vincent Sanders2015-05-031-9/+19
| | | | | | | This makes the box_move_xy function return a value on all code paths. This was not really necessary as there is an assert in the path that could have returned without a value. The gcc optimiser seems unable to reason about this in this case causing a warning.
* Ensure result of ftell is checked for errorsVincent Sanders2015-04-261-0/+6
| | | | | | | | The ftell call in the html renderer handling of drag and drop was not checking its return value for errors which could have resulted in attempting to read -1 bytes. coverity 1251038
* Remove duplicate branch in relative position handling.Michael Drake2015-04-231-5/+5
|
* Ensure we delink form controls when freeing themDaniel Silverstone2015-04-221-0/+19
|
* add some debug to form gadget freeingVincent Sanders2015-03-271-3/+10
| | | | | Serveral reports of form freeing segfaulting on RISC OS so this adds some debug in this area to see if we can tell why.
* To avoid namespace conflicts with ncurses add NetSurf key prefix.Witold Filipczyk2015-03-273-12/+12
| | | | Adds a NetSurf key code prefix of NS_ to all key codes.
* Forms: consider submit buttons successful. Fixes #2284.John-Mark Bell2015-03-101-2/+47
|
* Add invalidate API to html content script handling and use it.Vincent Sanders2015-03-093-25/+66
| | | | | | | | | | The html content script handling needs to invalidate its JavaScript context when the browsing context (browser_window) containing it is either closed or the content fetch is aborted (stopped) Previously the invalidation was only done on browser_window close which resulted in use after free crashes because of the now invalid JavaScript context.
* clear the html content reference to javascript context.Vincent Sanders2015-03-061-0/+8
| | | | | | | | | | | | When the browser window is about to be destroyed html_close gets called indicating the browser_window previously associated with the html content is about to become invalid. This makes the javascript context invalid within the html content (it is held by the browser window) when that context is about to be destroyed. Previously the javascript children would continue to attempt to use the context after it had been destroyed causing all sorts of strange errors and failures.
* Remove nsurl include.Michael Drake2015-02-261-3/+2
|
* Revert removal of implied table adding.Michael Drake2015-01-271-2/+52
| | | | | Even if the DOM is always sanitised, CSS display property can cause other boxes to be required.
* Remove unused variables.Michael Drake2015-01-241-3/+0
|
* Remove redundant implied table insertion.Michael Drake2015-01-241-49/+2
|
* release gadget allocation on error path (Coverity 1109875)Vincent Sanders2014-11-301-0/+1
|
* Fix my spelling of teh everywhereVincent Sanders2014-11-181-1/+1
|
* Remove unecessary form debugVincent Sanders2014-11-151-33/+37
| | | | | Additionaly we make the curl fetcher report errors instead of uninitialised buffer.
* Fix cocoa usage of render internalsVincent Sanders2014-11-132-0/+18
|
* make the form select menu API smaller.Vincent Sanders2014-11-134-93/+129
| | | | | | By hiding all but the form selection menu option structure from code outside of render this reduces the API to the absolute minimum to support this feature.
* doxgen warning fixes in riscos frontend.Vincent Sanders2014-11-121-25/+30
|
* cleanup Doxygen warningsVincent Sanders2014-11-124-40/+41
|
* Doxygen cleanupsVincent Sanders2014-11-126-29/+34
|
* Doxygen cleanupsVincent Sanders2014-11-123-79/+89
|
* change form API to return error instead of warning user.Vincent Sanders2014-11-112-14/+31
| | | | | | | Update the form API so instead of directly warning the user it returns an error code to the caller allowing the appropriate action to be taken outside the core. Additionally clean up documentation of this API.
* Make most of the form API internal to the html renderer.Vincent Sanders2014-11-1110-113/+151
| | | | | | Very little of the form API needed exposing outside of the renderer. This makes the form API that may be used by frontends obvious and limited.
* Doxygen warning fixesVincent Sanders2014-11-103-9/+9
|
* address even more potential leaks on error path in box_select (coverity 1109875)Vincent Sanders2014-11-101-1/+3
|
* fix leak of gadget on error path. (coverity 1109875)Vincent Sanders2014-11-101-2/+6
|
* Fix reference to local variable outside scope (fixes coverity 1251161)Vincent Sanders2014-11-101-1/+1
|
* remove declaration in parameter list warning in form.hVincent Sanders2014-11-091-0/+1
|
* fix up more doxygen errorsVincent Sanders2014-11-081-0/+2
|
* Improve Doxygen documentationVincent Sanders2014-11-082-18/+22
|
* Improve content encoding information APIVincent Sanders2014-11-072-16/+7
| | | | | Extend the content_get_encoding() API to retrieve the source of the encoding as well as the actual encoding.
* Allow content handlers to have debug values set through APIVincent Sanders2014-11-063-5/+20
| | | | | | | | Previously content handler debugging features were accessed by global variables. This allows the setting of debugging parameters via a content API giving per content control over debugging features. Currently only used by the html content handler to toggle global redraw debugging.
* Make the fetching of a contents encoding generic.Vincent Sanders2014-11-052-6/+6
| | | | | | | The frontends previously had to use an html renderer API to get the encoding of a content. This also required the explicit checking of the contents type rather than using the existing content API to abstract this knowledge.
* replace save_link operation table entry usage of textural url with nsurlVincent Sanders2014-11-031-1/+1
|
* remove unecessary utils/types.hVincent Sanders2014-11-022-9/+10
| | | | | | This cleans up this header and moves the functionality into more useful places while reducing the include complexity but only pulling in whats required.
* Change contextual content retrieval to browser features.Vincent Sanders2014-11-021-17/+19
| | | | | | | | | | | | | Update the API which allows frontends to acquire the page features (images, link urls or form elements) present at the given coordinates within a browser window. By making this an explicit browser_window API and using the browser.h header for the associated data structure with a more appropriate API naming the usage is much more obvious and contained. Additionally the link url is now passed around as a nsurl stopping it being converted from nsurl to text and back again several times.
* make the pseudo css fetcher report initialisation errorsVincent Sanders2014-10-253-9/+18
|
* Add bw function to get scrollbar type.Michael Drake2014-10-252-9/+10
|
* Open select menu via content msg, instead of breaking encapsulation.Michael Drake2014-10-242-11/+4
| | | | Fixes bw deref and browser_private.h #include in render/
* remove unecessary browser.h include from core headersVincent Sanders2014-10-176-9/+14
|
* Update the core to use the split operations table headersVincent Sanders2014-10-166-10/+16
| | | | Second in the series to decouple the core API usage from the frontends.
* Fix with ugly -- but commented -- hack.Michael Drake2014-10-161-0/+7
|
* Fix core create_form_select_menu API to pass gw, rather than bw out to front ↵Michael Drake2014-10-161-2/+6
| | | | ends.
* Remove trailing whitespace.Michael Drake2014-10-151-93/+93
|