From 03624bcf7a0128979be1a9c60852cb230b9dc0db Mon Sep 17 00:00:00 2001 From: Daniel Silverstone Date: Sun, 9 Jun 2019 15:20:17 +0100 Subject: browser.c: Don't require > 0 chars in logging Sometimes JavaScript chooses to log an empty string. We should honour that by requiring msg be a valid empty string. Signed-off-by: Daniel Silverstone --- desktop/browser.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/desktop/browser.c b/desktop/browser.c index f18768b40..a3664ac37 100644 --- a/desktop/browser.c +++ b/desktop/browser.c @@ -3458,7 +3458,10 @@ nserror browser_window_console_log(struct browser_window *bw, struct browser_window *root = browser_window_get_root(bw); assert(msg != NULL); - assert(msglen > 0); + /* We don't assert msglen > 0, if someone wants to log a real empty + * string then we won't stop them. It does sometimes happen from + * JavaScript for example. + */ /* bw is the target of the log, but root is where we log it */ -- cgit v1.2.3