From 05ac4303058588a77b12e25951d378498a9b3449 Mon Sep 17 00:00:00 2001 From: Vincent Sanders Date: Tue, 6 Nov 2018 21:59:50 +0000 Subject: ensure filename numeric is not truncated and hence cause output buffer overflow --- utils/filename.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/utils/filename.c b/utils/filename.c index f0e1bb0f5..00ade7409 100644 --- a/utils/filename.c +++ b/utils/filename.c @@ -96,7 +96,9 @@ const char *filename_request(void) else dir->high_used |= (1 << (i - 32)); - sprintf(filename_buffer, "%s%.2i", dir->prefix, i); + i = i % 99; + + snprintf(filename_buffer, sizeof(filename_buffer), "%s%.2i", dir->prefix, i); return filename_buffer; } -- cgit v1.2.3