From e201597a8dd9ba0aee21c0afbc699e76efe99efc Mon Sep 17 00:00:00 2001
From: Michael Drake <michael.drake@codethink.co.uk>
Date: Mon, 18 May 2020 21:53:28 +0100
Subject: Page info: Improve certificate fault display style.

---
 content/fetchers/about.c | 15 +++++++++------
 resources/internal.css   |  4 ----
 2 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/content/fetchers/about.c b/content/fetchers/about.c
index 3b8147390..796b39091 100644
--- a/content/fetchers/about.c
+++ b/content/fetchers/about.c
@@ -1262,9 +1262,16 @@ format_certificate(struct fetch_about_context *ctx,
 
 	if (cert_info->err != SSL_CERT_ERR_OK) {
 		res = ssenddataf(ctx,
-				 "<div class=\"error\">\n"
-				 "<p><b>%s</b></p>\n",
+				 "<table class=\"info\">\n"
+				 "<tr class=\"ns-even-fg-bad\">"
+				 "<th>Fault</th>"
+				 "<td>%s</td>"
+				 "</tr>"
+				 "</table>\n",
 				 messages_get_sslcode(cert_info->err));
+		if (res != NSERROR_OK) {
+			return res;
+		}
 	}
 
 	res = ssenddataf(ctx,
@@ -1359,10 +1366,6 @@ format_certificate(struct fetch_about_context *ctx,
 		return res;
 	}
 
-	if (cert_info->err != SSL_CERT_ERR_OK) {
-		res = ssenddataf(ctx, "</div>\n");
-	}
-
 	return res;
 }
 
diff --git a/resources/internal.css b/resources/internal.css
index d6278ca6a..a6b666b67 100644
--- a/resources/internal.css
+++ b/resources/internal.css
@@ -214,10 +214,6 @@ body#certificate table.info td.data {
 	font-size: 90%;
 }
 
-body#certificate div.error {
-    background: #FFEAEA;
-}
-
 
 /* 
  * configuration listing style 
-- 
cgit v1.2.3