From dbf02c37f4f1652561b9542530dd93b3ba310e9f Mon Sep 17 00:00:00 2001
From: Vincent Sanders <vince@kyllikki.org>
Date: Mon, 6 May 2019 12:03:08 +0100
Subject: complete basic binding documentation

improve the alert() method parameter handling
---
 content/handlers/javascript/duktape/Window.bnd | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

(limited to 'content/handlers/javascript')

diff --git a/content/handlers/javascript/duktape/Window.bnd b/content/handlers/javascript/duktape/Window.bnd
index cfc6f1fdb..5283a14ad 100644
--- a/content/handlers/javascript/duktape/Window.bnd
+++ b/content/handlers/javascript/duktape/Window.bnd
@@ -322,9 +322,19 @@ setter Window::name()
 
 method Window::alert()
 %{
-	duk_size_t msg_len;
-	const char *msg = duk_safe_to_lstring(ctx, 0, &msg_len);
-	NSLOG(netsurf, INFO, "JS ALERT: %*s", (int)msg_len, msg);
+	duk_idx_t dukky_argc = duk_get_top(ctx);
+	if (dukky_argc == 0) {
+		NSLOG(netsurf, INFO, "JS ALERT");
+	} else {
+		duk_size_t msg_len;
+		const char *msg;
+
+		if (!duk_is_string(ctx, 0)) {
+			duk_to_string(ctx, 0);
+		}
+		msg = duk_safe_to_lstring(ctx, 0, &msg_len);
+		NSLOG(netsurf, INFO, "JS ALERT: %*s", (int)msg_len, msg);
+	}
 	return 0;
 %}
 
-- 
cgit v1.2.3