From 885897f610b9b3650d061b17ef58d6493287488b Mon Sep 17 00:00:00 2001 From: Michael Drake Date: Sat, 9 Nov 2019 17:14:37 +0000 Subject: llcache: Uncachable scheme checks don't need to be caseless. --- content/llcache.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) (limited to 'content') diff --git a/content/llcache.c b/content/llcache.c index 1e874800c..54848cfaf 100644 --- a/content/llcache.c +++ b/content/llcache.c @@ -1798,16 +1798,18 @@ llcache_object_retrieve(nsurl *url, scheme = nsurl_get_component(defragmented_url, NSURL_SCHEME); - if (lwc_string_caseless_isequal(scheme, corestring_lwc_http, + /* nsurl ensures lower case schemes, and corestrings are lower + * case, so it's safe to use case-sensitive comparison. */ + if (lwc_string_isequal(scheme, corestring_lwc_http, &match) == lwc_error_ok && (match == false) && - lwc_string_caseless_isequal(scheme, corestring_lwc_https, + lwc_string_isequal(scheme, corestring_lwc_https, &match) == lwc_error_ok && (match == false) && - lwc_string_caseless_isequal(scheme, corestring_lwc_resource, + lwc_string_isequal(scheme, corestring_lwc_resource, &match) == lwc_error_ok && (match == false) && - lwc_string_caseless_isequal(scheme, corestring_lwc_file, + lwc_string_isequal(scheme, corestring_lwc_file, &match) == lwc_error_ok && (match == false)) { uncachable = true; -- cgit v1.2.3