From 9cf51227979c84a9ed74c339290c3f65f0d58c4f Mon Sep 17 00:00:00 2001 From: John Mark Bell Date: Sun, 11 Mar 2007 22:08:57 +0000 Subject: Content handlers should not call warn_user - they should broadcast the error using content_broadcast and leave it to the content owner(s) to decide what to do about it. Only use warn_user for top-level contents. svn path=/trunk/netsurf/; revision=3204 --- content/content.c | 4 ---- 1 file changed, 4 deletions(-) (limited to 'content') diff --git a/content/content.c b/content/content.c index 446f326db..93d37d799 100644 --- a/content/content.c +++ b/content/content.c @@ -535,7 +535,6 @@ bool content_set_type(struct content *c, content_type type, c->status = CONTENT_STATUS_ERROR; msg_data.error = messages_get("NoMemory"); content_broadcast(c, CONTENT_MSG_ERROR, msg_data); - warn_user("NoMemory", 0); return false; } @@ -556,7 +555,6 @@ bool content_set_type(struct content *c, content_type type, msg_data.error = messages_get("NoMemory"); content_broadcast(c, CONTENT_MSG_ERROR, msg_data); - warn_user("NoMemory", 0); return false; } @@ -574,7 +572,6 @@ bool content_set_type(struct content *c, content_type type, msg_data.error = messages_get("NoMemory"); content_broadcast(c, CONTENT_MSG_ERROR, msg_data); - warn_user("NoMemory", 0); return false; } content_remove_user(c, callback, p1, p2); @@ -682,7 +679,6 @@ bool content_process_data(struct content *c, const char *data, c->status = CONTENT_STATUS_ERROR; msg_data.error = messages_get("NoMemory"); content_broadcast(c, CONTENT_MSG_ERROR, msg_data); - warn_user("NoMemory", 0); return false; } c->source_data = source_data; -- cgit v1.2.3