From 3c707fbeea2977862db869a27615eb5b194e71e6 Mon Sep 17 00:00:00 2001
From: James Bursa <james@netsurf-browser.org>
Date: Fri, 21 May 2004 22:51:02 +0000
Subject: [project @ 2004-05-21 22:51:02 by bursa] Fix <select>, which got
 broken earlier.

svn path=/import/netsurf/; revision=882
---
 render/box.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

(limited to 'render')

diff --git a/render/box.c b/render/box.c
index 8e8009495..656b9923f 100644
--- a/render/box.c
+++ b/render/box.c
@@ -948,7 +948,7 @@ struct box_result box_select(xmlNode *n, struct box_status *status,
 	xmlNode *c, *c2;
 
 	gadget = form_new_control(GADGET_SELECT);
-	if (gadget)
+	if (!gadget)
 		return (struct box_result) {0, false, true};
 
 	if (status->current_form)
@@ -1050,7 +1050,8 @@ void add_option(xmlNode* n, struct form_control* current_select, char *text)
 	current_select->data.select.last_item = option;
 
 	if ((s = (char *) xmlGetProp(n, (const xmlChar *) "value"))) {
-		option->value = s;
+		option->value = xstrdup(s);
+		xmlFree(s);
 	} else {
 		option->value = xstrdup(text);
 	}
-- 
cgit v1.2.3